Repository navigation
feat(stovepipe): Pass terminal build to resolver - #757
Merged
Conversation
This was referenced Sep 29, 2026
prathshenoy
changed the title
prathshenoy
added this pull request to stack #755
September 29, 2026 01:45
1 task done
prathshenoy
marked this pull request as ready for review
September 29, 2026 13:35
prathshenoy
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 29, 2026 13:35
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 17:18
485d573 to
ec745fb
Compare
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 17:20
ec745fb to
716e4b3
Compare
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 17:27
716e4b3 to
aacd25d
Compare
mnoah1
approved these changes
Sep 29, 2026
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 22:22
aacd25d to
8d214b3
Compare
prathshenoy
changed the title
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 22:28
8d214b3 to
0bc351f
Compare
**What**: - Pass each request’s terminal build identity to project resolution. **Why**: - Let project resolution retrieve results from the build that established the request outcome.
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-terminal-build
branch
from
September 29, 2026 22:30
0bc351f to
a4f85b0
Compare
prathshenoy
temporarily deployed
to
stack-rebase
September 30, 2026 00:09 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
behinddwalls
deleted the
prath.shenoy/stovepipe-project-result-terminal-build
branch
September 30, 2026 00:10
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Oct 5, 2026
## Summary **What**: - Store the build ID that establishes a request's terminal state. **Why**: - Make the terminal build direct request state for downstream resolution. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. No downstream consumer needs the terminal build identity currently. ## Issues - [CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver) ## Stack 1. @ uber#752 1. uber#754 1. uber#756 1. uber#757 1. uber#758
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Oct 5, 2026
## Summary **What**: - Persist the terminal build ID together with a request's terminal state. **Why**: - Ensure the first terminal build also becomes the request’s recorded terminal build. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. It only stops terminal transitions from populating the nullable field; existing request state remains unchanged. ## Issues - [CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver) ## Stack 1. uber#752 1. @ uber#754 1. uber#756 1. uber#757 1. uber#758
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Oct 5, 2026
## Summary **What**: - Record the terminal build ID with a request's terminal history when a build establishes the state. **Why**: - Preserve durable history showing which build established the request’s final state. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. Terminal history is supplementary and does not change request state or project resolution. ## Issues - [CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver) ## Stack 1. uber#752 1. uber#754 1. @ uber#756 1. uber#757 1. uber#758
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Oct 5, 2026
## Summary **What**: - Document how a terminal build ID is stored on a request and provided to project resolution. **Why**: - Keep the RFC aligned with the request-side terminal-build behavior. ## Test Plan - [x] Ask an agent to find inconsistencies between the docs and the code. ## Revert Plan - Revert this PR. The changes in this PR include documentation only. ## Issues - [CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver) ## Stack 1. uber#752 1. uber#754 1. uber#756 1. uber#757 1. @ uber#758
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
Test Plan
Revert Plan
Issues
Stack